Disallow intercept of touch event #953
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlesroddie
previously approved these changes
Sep 7, 2019
|
Changes look good to me. @mattleibow can you take a quick look and merge if OK? And when this is merged, can SkiaSharp(.Views.Forms) be released? Last release was 9 months ago: is there a problem in master preventing releases? |
|
Can this be pushed into 1.68.1 @mattleibow ? |
|
just curious when it will be a turn of the PR to get some feedback/decision |
|
Sorry about the delay folks, I was busy getting things working again and then fixing a few issues. |
|
Moved comment to issue: #937 (comment) |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Added call to
RequestDisallowInterceptTouchEvent.Tests aren't provided - not sure is it required.
Bugs Fixed
Fixed: #937
PR Checklist